Fix NPM dependency issues and Java7 issues#49
Merged
asadm merged 2 commits intoremoteinterview:masterfrom Nov 16, 2017
Merged
Conversation
This fixes what was a breaking build of the Dockerfile.
Since newer version unbundle and reorganize the structure: * add an explicit dependency on body-parser * create a server via 'http' rather than express directly
Contributor
|
Awesome! Since you have tested the install (and java 8 compilation too?) I will go ahead and merge. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8080since80appears to be blocked by default on Ubuntu 16.04With these changes an a fresh Ubuntu 16.04 VM, the install scripts all work without any necessary tweaking. I haven't tested the other targeted platforms, would be happy to adjust this PR if necessary.