ENG-9830 fix: avoid config re-entry when a State is defined in rxconfig.py#6662
ENG-9830 fix: avoid config re-entry when a State is defined in rxconfig.py#6662FarhanAliRaza wants to merge 2 commits into
Conversation
State-class creation read get_config().state_auto_setters at class-creation time, which re-entered config loading while rxconfig.py was still importing and raised AttributeError. Cache the flag when the Config is built and read it via get_state_auto_setters(), falling back to the env var before any Config exists.
Greptile SummaryThis PR fixes an
Confidence Score: 5/5Safe to merge β the change is minimal and targeted, replacing one call site in The fix is narrowly scoped: one call-site change in No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "docs: add changelog entries for config r..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
State-class creation read get_config().state_auto_setters at class-creation time, which re-entered config loading while rxconfig.py was still importing and raised AttributeError. Cache the flag when the Config is built and read it via get_state_auto_setters(), falling back to the env var before any Config exists.
All Submissions:
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update
New Feature Submission:
Changes To Core Features:
closes #6661