Allow overriding files with Plugins, just warn about it#6476
Allow overriding files with Plugins, just warn about it#6476masenf merged 6 commits intoreflex-dev:mainfrom
Conversation
Greptile SummaryThis PR fixes a bug where plugins could not override compile-time files — previously the plugin file was silently ignored if the path already existed in
Confidence Score: 4/5Safe to merge; the plugin override fix is correct and the diff is minimal. The plugin static-assets fix is straightforward and correct. The only concern is that the compile_results loop also quietly switches from first-wins to last-wins, which is a real behavior change not mentioned in the PR description. In practice duplicate compile_results paths would indicate a compilation bug, so the impact is low — but it's worth a confirmation from the author before merging. reflex/compiler/compiler.py — specifically the compile_results duplicate-path handling around line 1247. Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'reflex-dev:main' into main" | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
This fixes a bug where any
Pluginwould not be able to override any compile-time files.All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features: