Skip to content

add search to navbar#1761

Closed
carlosabadia wants to merge 4 commits intomainfrom
carlos/add-search-to-landing
Closed

add search to navbar#1761
carlosabadia wants to merge 4 commits intomainfrom
carlos/add-search-to-landing

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR adds a search bar to the marketing navbar by integrating the existing Inkeep search component. The main changes include adding a custom_style parameter to the search components to enable style customization, refactoring JavaScript configuration in inkeep.py to properly escape braces for f-string interpolation, and integrating the search bar into the marketing navigation menu with responsive design adjustments.

Key Changes:

  • Added custom_style parameter throughout the search component hierarchy to allow custom CSS injection
  • Refactored JavaScript object literals from single braces to double braces for proper f-string escaping
  • Added search bar to marketing navbar with custom styles to hide text and adjust container sizing
  • Made logo margin responsive (lg:mr-9 instead of mr-9)
  • Made Sign In button icon hide on smaller screens (max-lg:hidden)
  • Removed a comment explaining breadcrumb logic in the getTabs() function

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI additions with proper parameter threading. The main refactoring (brace escaping) is necessary for f-string interpolation. One minor issue: a potentially useful comment was removed without clear justification.
  • No files require special attention

Important Files Changed

Filename Overview
pcweb/components/docpage/navbar/inkeep.py Refactored JavaScript configuration to use double braces for f-string escaping, added custom_style parameter, and removed a comment
pcweb/components/docpage/navbar/search.py Added custom_style parameter to search_bar function for style customization
pcweb/views/marketing_navbar.py Added search bar to marketing navbar with custom styling and responsive adjustments

Last reviewed commit: 569ae0c

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@Alek99
Copy link
Member

Alek99 commented Feb 27, 2026

I dont like the way this looks well need to rethink

@Alek99
Copy link
Member

Alek99 commented Mar 2, 2026

not a fan of how this looks still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants