Skip to content

auto-docs: Update @redpanda-data/docs-extensions-and-macros#1725

Merged
Feediver1 merged 1 commit into
v/25.1from
update/docs-extensions-and-macros-v/25.1
Jun 3, 2026
Merged

auto-docs: Update @redpanda-data/docs-extensions-and-macros#1725
Feediver1 merged 1 commit into
v/25.1from
update/docs-extensions-and-macros-v/25.1

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Contributor

This PR updates @redpanda-data/docs-extensions-and-macros using npm update.

@vbotbuildovich vbotbuildovich requested a review from a team as a code owner June 2, 2026 16:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71a40a71-e72b-4bc4-899e-324e45de3d19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update/docs-extensions-and-macros-v/25.1

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs standards review (automated dep bump, v/25.1 maintenance branch)

Files reviewed: 1 (package-lock.json, +3/-3). Not an .adoc content PR — automated dependency-bump bot PR. Third in a trio with #1726 (main) and #1727 (v/24.3), all opened by the same bot within ~9 seconds of each other.

The trio at a glance

PR Base Bump
#1725 (this one) v/25.1 4.17.04.17.3
#1726 main 5.0.05.0.3
#1727 v/24.3 4.17.04.17.3

The two maintenance branches (v/24.3 and v/25.1) are pinned to the 4.17.x stable line; main is on the 5.x major. This PR's diff is functionally identical to #1727 — patch-only bump within the same minor.

Critical issues

None.

Suggestions

  1. CI is missing Netlify, header-rules, pages-changed, and redirect-rules checks that the sibling PR #1727 has on v/24.3. Currently #1725 only shows:

    setup: SUCCESS
    run-tests (ubuntu-latest): SUCCESS
    CodeRabbit: SUCCESS
    

    No netlify/redpanda-docs-preview/deploy-preview check ran. Two possibilities: (a) v/25.1 isn't configured for Netlify previews (likely if v/25.1 is too new to be in the Netlify site config), or (b) the Netlify integration failed silently. Worth confirming before merge — if the branch normally gets a preview and this PR didn't, you're merging without the live-build verification the other branches get.

  2. Same auto-merge process question as #1726 / #1727 — three nearly-identical bot PRs sitting unmerged is exactly the kind of work that should auto-merge after green CI.

  3. PR description is minimal ("This PR updates @redpanda-data/docs-extensions-and-macros using npm update."). Same comment as the siblings — a link to the source PRs that produced 4.17.3 would help reviewers know what's actually changing. Out of scope; bot-config tweak.

Impact on other files

  • No .adoc content changes — pure dependency manifest update.
  • Behavior change risk on v/25.1 is bounded by 4.17.x being patch-only. Whatever changed in 4.17.1 / 4.17.2 / 4.17.3 should be backwards-compatible per semver. Unlike #1726 (5.0.0 → 5.0.3) which packs in substantive behavior changes from extensions#201, this v/25.1 line is the conservative branch and should carry fewer changes.
  • Missing Netlify preview means no live verification that the v/25.1 build still renders correctly post-bump. Without that signal, the risk is slightly higher than #1727 (which has the preview green).

CodeRabbit findings

None — CodeRabbit doesn't post on package-lock-only diffs.

What works well

  • Single-file, lockfile-only diff — easy to verify, easy to revert.
  • Patch-only bump within a single minor (4.17.x) — expected backwards-compatible per semver.
  • Same predecessor cadence holds for v/25.1 as for v/24.3 — bot has been running these consistently.

Verdict

Same routine bot bump as #1727, just on a different maintenance branch. The missing Netlify preview check is the one thing that distinguishes it from its v/24.3 sibling — worth investigating whether v/25.1 should be getting previews (and if so, why this one didn't run) before merging, since the live build is the cheapest sanity check available for these bumps.

@Feediver1 Feediver1 merged commit b90700b into v/25.1 Jun 3, 2026
5 checks passed
@Feediver1 Feediver1 deleted the update/docs-extensions-and-macros-v/25.1 branch June 3, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants