auto-docs: Update @redpanda-data/docs-extensions-and-macros#1725
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Feediver1
left a comment
There was a problem hiding this comment.
Docs standards review (automated dep bump, v/25.1 maintenance branch)
Files reviewed: 1 (package-lock.json, +3/-3). Not an .adoc content PR — automated dependency-bump bot PR. Third in a trio with #1726 (main) and #1727 (v/24.3), all opened by the same bot within ~9 seconds of each other.
The trio at a glance
| PR | Base | Bump |
|---|---|---|
| #1725 (this one) | v/25.1 |
4.17.0 → 4.17.3 |
| #1726 | main |
5.0.0 → 5.0.3 |
| #1727 | v/24.3 |
4.17.0 → 4.17.3 |
The two maintenance branches (v/24.3 and v/25.1) are pinned to the 4.17.x stable line; main is on the 5.x major. This PR's diff is functionally identical to #1727 — patch-only bump within the same minor.
Critical issues
None.
Suggestions
-
CI is missing Netlify, header-rules, pages-changed, and redirect-rules checks that the sibling PR #1727 has on v/24.3. Currently #1725 only shows:
setup: SUCCESS run-tests (ubuntu-latest): SUCCESS CodeRabbit: SUCCESSNo
netlify/redpanda-docs-preview/deploy-previewcheck ran. Two possibilities: (a) v/25.1 isn't configured for Netlify previews (likely if v/25.1 is too new to be in the Netlify site config), or (b) the Netlify integration failed silently. Worth confirming before merge — if the branch normally gets a preview and this PR didn't, you're merging without the live-build verification the other branches get. -
Same auto-merge process question as #1726 / #1727 — three nearly-identical bot PRs sitting unmerged is exactly the kind of work that should auto-merge after green CI.
-
PR description is minimal (
"This PR updates @redpanda-data/docs-extensions-and-macros using npm update."). Same comment as the siblings — a link to the source PRs that produced 4.17.3 would help reviewers know what's actually changing. Out of scope; bot-config tweak.
Impact on other files
- No
.adoccontent changes — pure dependency manifest update. - Behavior change risk on v/25.1 is bounded by 4.17.x being patch-only. Whatever changed in 4.17.1 / 4.17.2 / 4.17.3 should be backwards-compatible per semver. Unlike #1726 (5.0.0 → 5.0.3) which packs in substantive behavior changes from extensions#201, this v/25.1 line is the conservative branch and should carry fewer changes.
- Missing Netlify preview means no live verification that the v/25.1 build still renders correctly post-bump. Without that signal, the risk is slightly higher than #1727 (which has the preview green).
CodeRabbit findings
None — CodeRabbit doesn't post on package-lock-only diffs.
What works well
- Single-file, lockfile-only diff — easy to verify, easy to revert.
- Patch-only bump within a single minor (4.17.x) — expected backwards-compatible per semver.
- Same predecessor cadence holds for v/25.1 as for v/24.3 — bot has been running these consistently.
Verdict
Same routine bot bump as #1727, just on a different maintenance branch. The missing Netlify preview check is the one thing that distinguishes it from its v/24.3 sibling — worth investigating whether v/25.1 should be getting previews (and if so, why this one didn't run) before merging, since the live build is the cheapest sanity check available for these bumps.
This PR updates
@redpanda-data/docs-extensions-and-macrosusingnpm update.