-
Notifications
You must be signed in to change notification settings - Fork 48
Configurable namespace for Iceberg #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d302371
b22a1b2
6c797c1
76d7e0f
9c55393
9cd4cc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,11 +130,15 @@ To configure your Redpanda cluster to enable Iceberg on a topic and integrate wi | |
| . Edit your cluster configuration to set the `iceberg_enabled` property to `true`, and set the catalog integration properties listed in the example below. | ||
| ifndef::env-cloud[] | ||
| + | ||
| By default, Redpanda creates Iceberg tables in a namespace called `redpanda`. Because AWS Glue provides a single catalog per account, each Redpanda cluster that writes to the same Glue catalog must use a distinct namespace to avoid table name collisions. To set a unique namespace, set config_ref:iceberg_default_catalog_namespace,true,properties/cluster-properties[`iceberg_default_catalog_namespace`] at the same time. This property cannot be changed after Iceberg is enabled. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| + | ||
| Run `rpk cluster config edit` to update these properties: | ||
| + | ||
| [,bash] | ||
| ---- | ||
| iceberg_enabled: true | ||
| # Set a custom namespace instead of the default "redpanda" | ||
| iceberg_default_catalog_namespace: ["<custom-namespace>"] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nvartolomei Based on the description for ENG-917 I included the property in this example without commenting it out or saying it's optional. Does that sound good, and should I also change the wording on 133 and be explicit that it's required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it strictly required @nvartolomei or just commonly needed because Glue uses a single catalog (or something like that) and so namespaces are the primary table isolation mechanism. Is that right?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not required as we have a default BUT, I believe, you almost always want to set it to something unique as in Glue you get only 1 catalog so once you create second cluster you'll start getting conflicts. This document should make this very clear to the user so they don't shoot themselves in the foot now or later. This section:
Suggested change by Claude:
Then, at each point where the user is prompted to enable Iceberg, the docs should actively prompt the user to evaluate whether a unique namespace is needed, with a cross-reference to the expanded rationale above.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nvartolomei Made the following edits: Explained table name collision risk with AWS Glue catalogs
Slightly more generic wording, recommending to check catalog requirements: https://deploy-preview-1622--redpanda-docs-preview.netlify.app/current/manage/iceberg/use-iceberg-catalogs/#configure-table-namespace Let me know if you recommend other changes |
||
| # Glue requires Redpanda Iceberg tables to be manually deleted | ||
| iceberg_delete: false | ||
| iceberg_catalog_type: rest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems imcomplete.
"at the same time" -> "at the same time iceberg is enabled"
or -> "while/before enabling iceberg"?