fix(DOC-2061): clarify schema reference name field per schema type#1613
fix(DOC-2061): clarify schema reference name field per schema type#1613
Conversation
Add a table explaining what the `name` field means in schema references for Protobuf (import path), Avro (fully qualified schema name), and JSON Schema (URI used in $ref). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe "Reference a schema" section in the schema registration API documentation was expanded to provide more prescriptive guidance on identifying schema references. The changes add explicit field definitions (name, subject, version), introduce a mapping table showing how the reference name field is interpreted differently across schema types (Protobuf, Avro, JSON Schema), and clarify that the semantic meaning of the name field is type-dependent. The existing Protobuf example remains intact. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/manage/pages/schema-reg/schema-reg-api.adoc`:
- Around line 660-662: Update the Avro description text under the "Avro" heading
so it does not assume a namespace is always present; change the sentence
describing the "fully qualified schema name" to explain that when a namespace
exists it combines namespace and record name (for example
`com.example.Address`), and when no namespace is defined the reference is just
the record name; target the string "The fully qualified schema name, combining
the namespace and record name (for example, `com.example.Address`)" and replace
it with the clarified wording.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 818ab3cf-13c1-474e-a77a-b2608584977f
📒 Files selected for processing (1)
modules/manage/pages/schema-reg/schema-reg-api.adoc
| | Avro | ||
| | The fully qualified schema name, combining the namespace and record name (for example, `com.example.Address`) | ||
|
|
There was a problem hiding this comment.
Avro wording should cover schemas without a namespace.
Current phrasing implies namespace is always present. For Avro records without namespace, the reference name is just the record name. Consider tweaking this sentence to avoid over-constraining users.
Suggested wording tweak
-| The fully qualified schema name, combining the namespace and record name (for example, `com.example.Address`)
+| The schema name used by Avro resolution: fully qualified (`namespace.name`) when a namespace is defined, or just the record name when it is not (for example, `com.example.Address` or `Address`)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | Avro | |
| | The fully qualified schema name, combining the namespace and record name (for example, `com.example.Address`) | |
| | Avro | |
| | The schema name used by Avro resolution: fully qualified (`namespace.name`) when a namespace is defined, or just the record name when it is not (for example, `com.example.Address` or `Address`) | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@modules/manage/pages/schema-reg/schema-reg-api.adoc` around lines 660 - 662,
Update the Avro description text under the "Avro" heading so it does not assume
a namespace is always present; change the sentence describing the "fully
qualified schema name" to explain that when a namespace exists it combines
namespace and record name (for example `com.example.Address`), and when no
namespace is defined the reference is just the record name; target the string
"The fully qualified schema name, combining the namespace and record name (for
example, `com.example.Address`)" and replace it with the clarified wording.
Summary
namefield means per schema type:.protofile$refResolves DOC-2061.
Test plan
🤖 Generated with Claude Code