Skip to content

ACL pages routing fix - removed AclPrincipalGroupEditor #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvorcak merged 2 commits into from
Mar 24, 2026
Merged

ACL pages routing fix - removed AclPrincipalGroupEditor #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9efd1
ACL pages routing fix - removed AclPrincipalGroupEditor
jvorcak Mar 23, 2026
8e0ccbd
Remove stale test from ACL
jvorcak Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions frontend/src/components/pages/acls/acl-list.roles.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,19 +224,11 @@ vi.mock('./delete-user-confirm-modal', () => ({
}));

vi.mock('./models', () => ({
createEmptyClusterAcl: vi.fn(),
createEmptyConsumerGroupAcl: vi.fn(),
createEmptyTopicAcl: vi.fn(),
createEmptyTransactionalIdAcl: vi.fn(),
principalGroupsView: {
principalGroups: [],
},
}));

vi.mock('./principal-group-editor', () => ({
AclPrincipalGroupEditor: () => null,
}));

vi.mock('./user-edit-modals', () => ({
ChangePasswordModal: () => null,
ChangeRolesModal: () => null,
Expand Down
30 changes: 0 additions & 30 deletions frontend/src/components/pages/acls/acl-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,8 @@ import { DeleteRoleConfirmModal } from './delete-role-confirm-modal';
import { DeleteUserConfirmModal } from './delete-user-confirm-modal';
import type { AclPrincipalGroup } from './models';
import {
createEmptyClusterAcl,
createEmptyConsumerGroupAcl,
createEmptyTopicAcl,
createEmptyTransactionalIdAcl,
principalGroupsView,
} from './models';
import { AclPrincipalGroupEditor } from './principal-group-editor';
import { ChangePasswordModal, ChangeRolesModal } from './user-edit-modals';
import { UserRoleTags } from './user-permission-assignments';
import ErrorResult from '../../../components/misc/error-result';
Expand Down Expand Up @@ -700,8 +695,6 @@ const AclsTab = (_: { principalGroups: AclPrincipalGroup[] }) => {
const invalidateUsersCache = useInvalidateUsersCache();

const [aclFailed, setAclFailed] = useState<{ err: unknown } | null>(null);
const [editorType, setEditorType] = useState<'create' | 'edit'>('create');
const [edittingPrincipalGroup, setEdittingPrincipalGroup] = useState<AclPrincipalGroup | null>(null);
const [searchQuery, setSearchQuery] = useState('');

const navigate = useNavigate();
Expand Down Expand Up @@ -768,18 +761,6 @@ const AclsTab = (_: { principalGroups: AclPrincipalGroup[] }) => {
width="300px"
/>
<Section>
{edittingPrincipalGroup ? (
<AclPrincipalGroupEditor
onClose={() => {
setEdittingPrincipalGroup(null);
api.refreshAcls(AclRequestDefault, true);
api.refreshServiceAccounts();
}}
principalGroup={edittingPrincipalGroup}
type={editorType}
/>
) : null}

<AlertDeleteFailed aclFailed={aclFailed} onClose={() => setAclFailed(null)} />

<Button
Expand All @@ -789,17 +770,6 @@ const AclsTab = (_: { principalGroups: AclPrincipalGroup[] }) => {
to: '/security/acls/create',
search: { principalType: undefined, principalName: undefined },
});
setEditorType('create');
setEdittingPrincipalGroup({
host: '',
principalType: 'User',
principalName: '',
topicAcls: [createEmptyTopicAcl()],
consumerGroupAcls: [createEmptyConsumerGroupAcl()],
transactionalIdAcls: [createEmptyTransactionalIdAcl()],
clusterAcls: createEmptyClusterAcl(),
sourceEntries: [],
});
}}
>
Create ACLs
Expand Down
Loading
Loading