customer-managed/azure: consume terraform-azure-redpanda-byovnet as a module#89
Open
sbocinec wants to merge 1 commit into
Open
customer-managed/azure: consume terraform-azure-redpanda-byovnet as a module#89sbocinec wants to merge 1 commit into
sbocinec wants to merge 1 commit into
Conversation
This directory was a line-identical copy of v1.0.0 of the published
terraform-azure-redpanda-byovnet module, which has since gained storage
account hardening, soft-delete on the management container, and the
`grant_caller_management_storage_access` variable.
Replace the duplicated .tf files with a single `module "byovnet"`
invocation against the registry (`redpanda-data/redpanda-byovnet/azure`,
~> 1.1). main.tf also carries `moved {}` blocks for every relocated
resource so existing deployments migrate in place with zero recreation.
Provider pin relaxed from azurerm = "=3.98.0" to "~> 3.98" so module
updates that require newer provider features keep working. Drops the
stale terraform-docs-generated terraform/README.md; variable docs now
live in the module's registry page.
Mirrors the AWS twin in #88.
sbocinec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop maintaining
customer-managed/azure/terraform/as a hand-copied duplicate of the publishedredpanda-data/redpanda-byovnet/azuremodule — consume the module instead. The local copy was pinned at v1.0.0 and had drifted (missing storage account hardening, management container soft-delete, and thegrant_caller_management_storage_accessvariable); switching to~> 1.1picks all of that up.Changes
.tffiles; replace with onemodule "byovnet"call pinned to~> 1.1from the registry.moved {}blocks so existing deployments migrate in place (terraform planshould be a no-op).module.byovnet.*(43 outputs, 1:1 name match).azurerm = "=3.98.0"→"~> 3.98"; lockfile refreshed to azurerm 3.117.1.terraform/README.md; variable docs now live in the module's registry page.Net: +394 / −1082 across 16 files.
Test plan
terraform fmt -check,init -upgrade,validateclean (one pre-existing deprecation warning is internal to the module)moved {}count matches module resource count (51 = 51)diff)terraform planagainst pre-refactor state reports no changesRefs