Skip to content

fix: avoid NLTK download race condition in parallel test workers #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bsbodden wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid NLTK download race condition in parallel test workers #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions redisvl/query/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,8 +1460,14 @@ def _set_stopwords(self, stopwords: Optional[Union[str, Set[str]]] = "english"):
self._stopwords = set()
elif isinstance(stopwords, str):
try:
nltk.download("stopwords", quiet=True)
self._stopwords = set(nltk_stopwords.words(stopwords))
# Try loading first; only download if not already present.
# This avoids race conditions when parallel workers (e.g.
# pytest-xdist) call nltk.download() concurrently.
try:
self._stopwords = set(nltk_stopwords.words(stopwords))
except LookupError:
nltk.download("stopwords", quiet=True)
self._stopwords = set(nltk_stopwords.words(stopwords))
except ImportError:
raise ValueError(
f"Loading stopwords for {stopwords} failed: nltk is not installed."
Expand Down
10 changes: 8 additions & 2 deletions redisvl/utils/full_text_query_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,14 @@ def _get_stopwords(
return set()
elif isinstance(stopwords, str):
try:
nltk.download("stopwords", quiet=True)
return set(nltk_stopwords.words(stopwords))
# Try loading first; only download if not already present.
# This avoids race conditions when parallel workers (e.g.
# pytest-xdist) call nltk.download() concurrently.
try:
return set(nltk_stopwords.words(stopwords))
except LookupError:
nltk.download("stopwords", quiet=True)
return set(nltk_stopwords.words(stopwords))
except ImportError:
raise ValueError(
f"Loading stopwords for {stopwords} failed: nltk is not installed."
Expand Down