Document 1.1 timestamp normalization behavior#815
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6ce865f | Previous: 704dc82 | Ratio |
|---|---|---|---|
tests/test_benchmarks.py::TestSaveBenchmarks::test_hashmodel_save |
1429.7247875576998 iter/sec (stddev: 0.00003725206351187) |
1798.7168889059508 iter/sec (stddev: 0.000047701004508117955) |
1.26 |
tests/test_benchmarks.py::TestSaveBenchmarks::test_jsonmodel_save |
2020.170023970168 iter/sec (stddev: 0.000043720840251137286) |
2543.7613439001443 iter/sec (stddev: 0.00004076731219692598) |
1.26 |
tests/test_benchmarks.py::TestSaveBenchmarks::test_jsonmodel_with_embedded_save |
1828.5096730098248 iter/sec (stddev: 0.00013239757452843194) |
2332.9339350448877 iter/sec (stddev: 0.00012885492021570306) |
1.28 |
tests/test_benchmarks.py::TestGetBenchmarks::test_hashmodel_get |
3008.8283838864886 iter/sec (stddev: 0.000013911162643384415) |
4249.161842197527 iter/sec (stddev: 0.000011161451291204753) |
1.41 |
tests/test_benchmarks.py::TestGetBenchmarks::test_jsonmodel_get |
2632.3774582875753 iter/sec (stddev: 0.000034324797026403676) |
3395.216587986375 iter/sec (stddev: 0.000022456019830359187) |
1.29 |
tests/test_benchmarks.py::TestGetBenchmarks::test_jsonmodel_with_embedded_get |
1667.8510076653954 iter/sec (stddev: 0.0016563374338772836) |
2100.337843543124 iter/sec (stddev: 0.0014949401095260472) |
1.26 |
tests/test_benchmarks.py::TestQueryBenchmarks::test_jsonmodel_find_by_field |
1571.2755493912541 iter/sec (stddev: 0.00003909219829691665) |
2085.714350071563 iter/sec (stddev: 0.00002873392296156053) |
1.33 |
tests/test_benchmarks.py::TestQueryBenchmarks::test_jsonmodel_find_with_pagination |
1019.7630694716553 iter/sec (stddev: 0.000034658759355505625) |
1253.8900999947432 iter/sec (stddev: 0.00003038493119767993) |
1.23 |
tests/test_benchmarks.py::TestUpdateBenchmarks::test_hashmodel_update |
1531.1473183905316 iter/sec (stddev: 0.00004153356533622611) |
1917.3786948314971 iter/sec (stddev: 0.000041631865549954885) |
1.25 |
tests/test_benchmarks.py::TestUpdateBenchmarks::test_jsonmodel_update |
2181.646172903454 iter/sec (stddev: 0.00003153207378807179) |
2644.5792116144776 iter/sec (stddev: 0.000023876960525226607) |
1.21 |
tests/test_benchmarks.py::TestBatchBenchmarks::test_jsonmodel_add_many |
595.4248388969279 iter/sec (stddev: 0.00009146884638973114) |
715.4241073457036 iter/sec (stddev: 0.00008086817412092368) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Users upgrading from older releases need a clear note that pre-1.1.0 date data written outside UTC may need migration or re-save after upgrading.
Note
Low Risk
Documentation-only changes; no runtime code paths or data handling logic are modified, so risk is limited to potential confusion from wording or guidance.
Overview
Documents the Redis OM Python 1.1.0 timestamp normalization behavior in
docs/migrations.md, calling out UTC-awaredatetime.datetimeround-tripping anddatetime.datebeing stored at midnight UTC, plus the upgrade impact on pre-1.1.0 data written outside UTC.Adds a new
docs/release_notes_1.1.mdpage covering the same timestamp changes (and the RedisVL compatibility note) and links it into the docs navigation viamkdocs.yml.Written by Cursor Bugbot for commit 6ce865f. This will update automatically on new commits. Configure here.