Prevent EmbeddedJsonModel from generating primary keys #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #496 - EmbeddedJsonModel was generating primary keys with ULIDs even though embedded models don't need them (they're stored as part of their parent document, not as separate Redis keys).
Changes
Field(default=None, exclude=True)so pk is excluded from serialization_meta.primary_keyfor embedded modelstest_schemato reflect that embedded model pk fields are no longer in the RediSearch schemaBefore
After