Merged
Conversation
valkirilov
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow and
pd-redis
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
DimoHG
reviewed
Mar 13, 2026
| name: Vector Search E2E Tests | ||
| overview: Update TEST_PLAN.md with ~37 flow-based Vector Search e2e test cases across 9 subsections, and implement the tests across 5 separate pull requests organized by functional area. | ||
| todos: | ||
| - id: pr1-infrastructure-and-navigation |
Contributor
There was a problem hiding this comment.
I'd just do that as a single PR with 5 commits. It shouldn't take long to review that.
Member
Author
There was a problem hiding this comment.
I think separate PRs work better here, because each one covers a specific area, so when you review it you only need to think about that one thing - like just the create index flow or just the query tests.
Mixing everything into one PR means you have to keep switching context between unrelated parts, which I find makes the review harder. The total effort is the same, but the individual reviews should be quicker.
Member
Author
There was a problem hiding this comment.
PS: If the code is not that much, I can combine it in a single PR 👍
DimoHG
previously approved these changes
Mar 13, 2026
KrumTy
previously approved these changes
Mar 13, 2026
dantovska
previously approved these changes
Mar 13, 2026
valkirilov
dismissed stale reviews from dantovska, KrumTy, and DimoHG
via
4e945cb
valkirilov
force-pushed
the
e2e/RI-7969/vector-search
branch
from
ca5ab40 to
4e945cb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
References: RI-7969
Add TypeScript types and Fishery factories for Vector Search E2E tests: - IndexSchemaField, IndexConfig, IndexHashKeyData, IndexJsonKeyData types - IndexConfigFactory, IndexHashKeyFactory, IndexJsonKeyFactory factories - StandaloneEmptyConfigFactory, StandaloneV7ConfigFactory database configs References: #RI-7969 Made-with: Cursor
Extend ApiHelper with methods for Vector Search E2E tests: createIndex, deleteIndex, deleteAllIndexes, getIndexes, sendCommand, createSavedQuery, deleteAllSavedQueries, deleteCommandExecutions. References: #RI-7969 Made-with: Cursor
Add Search tab navigation, vectorSearchPage fixture, and gotoDatabase scroll handling for Vector Search E2E tests. References: #RI-7969 Made-with: Cursor
Add View Index, Make Searchable, and Index folder button locators. Add selectKeyInTree, hoverFolderNode helpers and MakeSearchableModal POM. References: #RI-7969 Made-with: Cursor
Add VectorSearchPage and all component POMs: CreateIndexForm, CreateIndexOnboarding, IndexList, QueryEditor, QueryLibrary, QueryResults, SaveQueryModal, FieldTypeModal, and more. References: #RI-7969 Made-with: Cursor
Delete the previous Vector Search E2E test plan file as it has been replaced with a more comprehensive and updated version in the TEST_PLAN.md. References: #RI-7969 Made-with: Cursor
Tests for welcome screen, index list screen, and RQE not available screen when Redis lacks the search module. References: #RI-7969 Made-with: Cursor
Tests for select key onboarding dismissal, create index onboarding step-through, skip, and persistence after completion. References: #RI-7969 Made-with: Cursor
Tests for sample data modal flow, E-Commerce Discovery and Content Recommendations index creation via Start querying and See index definition. References: #RI-7969 Made-with: Cursor
Tests for creating indexes from existing hash/JSON keys with default settings, prefix editing, field management, name validation, and JSON key support. References: #RI-7969 Made-with: Cursor
Tests for index table display, query and browse navigation, index details side panel, and index deletion with confirmation. References: #RI-7969 Made-with: Cursor
Tests for sample data modal flows, existing data creation via list page menu, and disabled state when no hash/JSON keys exist. References: #RI-7969 Made-with: Cursor
Tests for running queries, result card interactions (expand, collapse, re-run, delete, clear), explain/profile actions, and button states. References: #RI-7969 Made-with: Cursor
Tests for query library onboarding popover dismissal and persistence after completion. References: #RI-7969 Made-with: Cursor
Tests for saving queries, navigating to query library via success toast action, and cancelling the save query modal. References: #RI-7969 Made-with: Cursor
Tests for searching/filtering saved queries, expand/collapse items, running and loading queries from library, and deleting with notification. References: #RI-7969 Made-with: Cursor
Tests for View Index button/dropdown, Make Searchable flow, Index button on folder nodes, and RQE not available from Browser. References: #RI-7969 Made-with: Cursor
…ethod Updated the logic for extracting the leaf name from the key name to account for the length of the delimiter, ensuring accurate substring extraction. References: #RI-7969 Made-with: Cursor
valkirilov
force-pushed
the
e2e/RI-7969/vector-search
branch
from
4e945cb to
f634372
Compare
…alue Added a new method `getKeysToScan` to the SettingsPage class for retrieving the current keys-to-scan value. e2e(vector-search): optimize browser page integration tests Refactored the browser page integration tests to utilize the `browserPage` object for navigation, removing redundant calls to `goto` for improved test efficiency. References: #RI-7969 Made-with: Cursor
Updated the `createIndex` method to accept an additional `keyType` parameter, allowing for the specification of 'hash' or 'json' types when creating indexes. This change improves flexibility in index creation commands. References: #RI-7969 Made-with: Cursor
Modified the `createIndex` method to format index name and prefix as quoted strings for consistency. Additionally, updated the `IndexSchemaFieldFactory` to generate field names using a new method for better randomness. References: #RI-7969 Made-with: Cursor
Updated the onboarding tests for vector search to include navigation to the application before localStorage operations. This change ensures that the correct origin is targeted during tests, improving reliability and consistency. References: #RI-7969 Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reorganized the onboarding steps in vector search tests to ensure navigation occurs before localStorage operations. This adjustment enhances test reliability by targeting the correct application origin during onboarding. References: #RI-7969 Made-with: Cursor
dantovska
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add comprehensive Playwright E2E test coverage for the Vector Search feature (55 tests across 11 spec files), covering navigation, index creation, query execution, query library, and browser page integration.
Note: The PR is quite big, so I would advise reviewing the PR plan or going through the commits separately, where you can see the different test suites instead of one large change set.
Infrastructure & prerequisites
TEST_PLAN.mdsection 8.1–8.12) — 2ba1c39, 09882adTest suites
Serial execution project
All Vector Search test suites are tagged with
@serialand run in the newchromium-serialPlaywright project (workers: 1,fullyParallel: false). This is necessary because the tests operate on shared RediSearch indexes (FT.CREATE / FT.DROPINDEX) on the same Redis instance, and parallel execution causes flakiness due to index name collisions and cleanup race conditions. The existingchromiumproject now excludes@serialtests viagrepInvert.Testing
Prerequisites
yarn dev:desktoporyarn dev:api && yarn dev:ui)Run all Vector Search tests
Run a specific spec file
Run with UI mode (for debugging)
npx playwright test tests/main/vector-search/ --uiNote
Medium Risk
Adds a large new E2E test suite and changes Playwright project configuration/CI execution, which may impact test runtime and stability (especially due to new serial-only tagging and Redis index cleanup behavior). No product runtime code is modified beyond test harness/page objects.
Overview
Adds comprehensive Playwright E2E coverage for Vector Search (navigation/RQE availability, index creation from sample/existing data, query execution/results, query onboarding, saving queries, query library CRUD, and Browser-page integration like View index / Make searchable).
Extends the E2E test harness to support these flows: new
VectorSearchPagepage-object model with supporting components/modals, new vector-search test data factories/types, andApiHelperhelpers to create/list/delete RediSearch indexes plus manage saved queries and SEARCH command history via the Workbench endpoint.Updates Playwright/CI to run
@serialVector Search tests in a newchromium-serialproject (single worker, not fully parallel) while excluding them from the regularchromiumproject; the GitHub workflow now runs both projects. Also includes small robustness tweaks to existing page objects (DB list pagination/reload ingotoDatabase, new Search tab navigation, and Browser key list/tree selectors for the updated UI).Written by Cursor Bugbot for commit c14318a. This will update automatically on new commits. Configure here.