RI-8039 [E2E] 7.3 Settings -> Workbench Settings#5593
Merged
Conversation
pd-redis
requested review from
KrumTy,
dantovska and
pawelangelow
as code owners
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
References: #RI-8039 Made-with: Cursor
pd-redis
force-pushed
the
e2e/RI-8039/workbench-settings
branch
from
0bdc3f2 to
08bc78f
Compare
KrumTy
previously approved these changes
Mar 9, 2026
The Section accordion from redis-ui renders headings, not buttons, for section labels. The collapse button has aria-label="Expand Section", not the section name. Updated isExpanded checks to use data-state on the accordion root element. Made-with: Cursor
…nctionality - Added new locators for pipeline commands value, input, and apply button in SettingsPage. - Implemented methods to toggle editor cleanup and manage pipeline commands in SettingsPage. - Expanded tests to verify persistence of editor cleanup and pipeline commands settings after navigation.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
…functionality - Added tests to ensure that enabling editor cleanup clears the editor after command execution, while disabling it retains the command in the editor. - Updated documentation to reflect the new behavior of Workbench settings.
- Refactored locators for pipeline commands to be scoped within the workbench settings section. - Adjusted the apply button locator to ensure it correctly references the form ancestor.
KrumTy
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Playwright E2E tests for the Workbench Settings section (7.3) of the Settings page.
Tests verify that the editor cleanup switch and pipeline commands setting are displayed when expanding the Workbench section. The "Configure command timeout" test case is N/A (per-database setting, not on the Settings page).
Testing
Run:
npx playwright test tests/main/settings/workbench-settingsCloses #RI-8039
Made with Cursor
Note
Medium Risk
Medium risk because it changes shared
SettingsPagelocators/expanded-state detection, which could affect other Settings E2E tests if the new selectors don’t match all UI variants; otherwise changes are test-only.Overview
Adds new Playwright E2E coverage for Settings → Workbench: verifies the editor cleanup switch and pipeline command batch size control are visible, persist after navigation, and that editor cleanup behavior actually affects Workbench command execution.
Updates the
SettingsPageobject to better match the accordion UI (heading-based toggles,data-statechecks), and adds scoped locators plus helper methods for editing/applying the pipeline commands value. Marks the corresponding Workbench settings cases as ✅ inTEST_PLAN.md.Written by Cursor Bugbot for commit b4bd146. This will update automatically on new commits. Configure here.