-
Notifications
You must be signed in to change notification settings - Fork 211
feat: add new drawer mount point #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The image is available at: /test e2e-ocp-helm |
7e2010f to
c539d1e
Compare
|
The image is available at: /test e2e-ocp-helm |
c539d1e to
bec5b87
Compare
|
|
The image is available at: /test e2e-ocp-helm |
|
@debsmita1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
Based on the spike https://docs.google.com/document/d/1nv2ITnWXeGiqjNVCFjhsEPL11M3zjha93y2KdS0ZPz0/edit?usp=sharing , this PR implements the following:
-> All two new mount points for dynamic plugins:
-
application/drawer-state: Exposes the plugin's drawer state (isDrawerOpen, drawerWidth, setDrawerWidth) to RHDH via callback props-
application/drawer-content: Defines the drawer's content component along with configuration options:id: Unique drawer identifier
priority: Numeric value determining render order (higher priority renders first)
resizable: Boolean to enable/disable drawer resizing
-> ApplicationDrawer Component, which renders all
application/drawer-statecomponents, collects drawer states via callback props, and filters for open drawers and renders the highest priority drawer contentWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer