chore(tests): smoke test refactor#1741
Conversation
|
/publish |
|
|
PR action ( |
|
|
|
This pull request has been automatically marked as stale due to inactivity. |
b34ebd4 to
7f7979e
Compare
1f10dbe to
2a6b15f
Compare
|
2a6b15f to
54d4c02
Compare
|
/publish |
|
PR action ( |
|
|
54d4c02 to
c80f1b9
Compare
|
/publish |
|
PR action ( |
|
|
c80f1b9 to
5a78cfa
Compare
|
/publish |
|
PR action ( |
|
|
|
/smoketest |
|
PR action ( |
|
|
||
| uploadPublishedExportsArtifact: | ||
| name: Upload published-exports artifact | ||
| upload_context: |
There was a problem hiding this comment.
Are we cool with mixed naming conventions here? There's some existing camel case used for steps/properties, this PR changes several of these to snake case but I'm pretty sure I also spotted some kebab case in this file too. Would it be better to align all of this to one convention in this refactor PR?
There was a problem hiding this comment.
yeah, there is a mix of naming conventions in the pr-actions file (perhaps intentionally @davidfestal?). changed naming to be consistent at least in the individual files related to smoke testing part.
8b0dd15 to
a90ac85
Compare
Signed-off-by: rostalan <rlan@redhat.com> Assisted-by: Cursor
a90ac85 to
e3f5851
Compare
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidfestal, gashcrumb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/publish |
|
PR action ( |
|
|



Uh oh!
There was an error while loading. Please reload this page.