Skip to content

chore(tests): smoke test refactor#1741

Merged
davidfestal merged 1 commit intoredhat-developer:mainfrom
rostalan:context-artifact-refactor
Feb 18, 2026
Merged

chore(tests): smoke test refactor#1741
davidfestal merged 1 commit intoredhat-developer:mainfrom
rostalan:context-artifact-refactor

Conversation

@rostalan
Copy link
Copy Markdown
Contributor

@rostalan rostalan commented Jan 8, 2026

  • merged the 3 nearly identical context artifact uploads into 1 conditional job to reduce code duplication.
  • merged 3 workspace test jobs to avoid duplicating the setup
  • removed redundant health check (covered by previous check)
  • rewrote the test summary in js and merged with previous job to reduce line count
  • unified naming conventions

@rostalan rostalan requested a review from davidfestal January 8, 2026 17:55
@rostalan rostalan requested review from a team, gashcrumb and kadel as code owners January 8, 2026 17:55
@rostalan
Copy link
Copy Markdown
Contributor Author

rostalan commented Jan 8, 2026

/publish

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2026

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2026

⚠️
Test workflow skipped: PR doesn't touch exactly one workspace.

@rostalan rostalan marked this pull request as draft January 8, 2026 18:11
@github-actions github-actions Bot added the non-workspace-changes PR changes files outside workspace directories label Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

This pull request has been automatically marked as stale due to inactivity.

@github-actions github-actions Bot added the stale label Feb 9, 2026
@rostalan rostalan force-pushed the context-artifact-refactor branch from b34ebd4 to 7f7979e Compare February 16, 2026 11:14
@rostalan rostalan force-pushed the context-artifact-refactor branch 3 times, most recently from 1f10dbe to 2a6b15f Compare February 16, 2026 12:33
@sonarqubecloud
Copy link
Copy Markdown

@rostalan rostalan force-pushed the context-artifact-refactor branch from 2a6b15f to 54d4c02 Compare February 16, 2026 12:34
@rostalan
Copy link
Copy Markdown
Contributor Author

/publish

@github-actions
Copy link
Copy Markdown
Contributor

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️
Smoke test workflow skipped: PR doesn't touch exactly one workspace.

@rostalan rostalan changed the title Context artifact refactor Smoke test refactor Feb 16, 2026
@rostalan rostalan force-pushed the context-artifact-refactor branch from 54d4c02 to c80f1b9 Compare February 16, 2026 14:47
@rostalan
Copy link
Copy Markdown
Contributor Author

/publish

@github-actions
Copy link
Copy Markdown
Contributor

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️
Smoke test workflow skipped: PR doesn't touch exactly one workspace.

@rostalan rostalan marked this pull request as ready for review February 16, 2026 14:55
@rostalan rostalan changed the title Smoke test refactor chore(tests): smoke test refactor Feb 16, 2026
@rostalan rostalan force-pushed the context-artifact-refactor branch from c80f1b9 to 5a78cfa Compare February 16, 2026 15:23
@rostalan rostalan removed the stale label Feb 16, 2026
@rostalan
Copy link
Copy Markdown
Contributor Author

/publish

@github-actions
Copy link
Copy Markdown
Contributor

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️
Smoke test workflow skipped: PR doesn't touch exactly one workspace.

@rostalan
Copy link
Copy Markdown
Contributor Author

/smoketest

@github-actions
Copy link
Copy Markdown
Contributor

PR action (/smoketest) cancelled: PR doesn't touch only 1 workspace.

Comment thread .github/workflows/pr-actions.yaml Outdated

uploadPublishedExportsArtifact:
name: Upload published-exports artifact
upload_context:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we cool with mixed naming conventions here? There's some existing camel case used for steps/properties, this PR changes several of these to snake case but I'm pretty sure I also spotted some kebab case in this file too. Would it be better to align all of this to one convention in this refactor PR?

Copy link
Copy Markdown
Contributor Author

@rostalan rostalan Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, there is a mix of naming conventions in the pr-actions file (perhaps intentionally @davidfestal?). changed naming to be consistent at least in the individual files related to smoke testing part.

@rostalan rostalan force-pushed the context-artifact-refactor branch 3 times, most recently from 8b0dd15 to a90ac85 Compare February 18, 2026 11:17
Signed-off-by: rostalan <rlan@redhat.com>

Assisted-by: Cursor
@rostalan rostalan force-pushed the context-artifact-refactor branch from a90ac85 to e3f5851 Compare February 18, 2026 11:18
@sonarqubecloud
Copy link
Copy Markdown

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidfestal, gashcrumb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidfestal
Copy link
Copy Markdown
Member

/publish

@github-actions
Copy link
Copy Markdown
Contributor

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

@davidfestal davidfestal merged commit 8b940ca into redhat-developer:main Feb 18, 2026
3 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

⚠️
Smoke test workflow skipped: PR doesn't touch exactly one workspace.

@rostalan rostalan deleted the context-artifact-refactor branch February 19, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm non-workspace-changes PR changes files outside workspace directories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants