Skip to content

RHIDP-11225: JTBD implementation for Scorecards#1669

Merged
deerskindoll merged 8 commits intoredhat-developer:mainfrom
pabel-rh:rhidp-11225
Jan 29, 2026
Merged

RHIDP-11225: JTBD implementation for Scorecards#1669
deerskindoll merged 8 commits intoredhat-developer:mainfrom
pabel-rh:rhidp-11225

Conversation

@pabel-rh
Copy link
Copy Markdown
Member

@pabel-rh pabel-rh commented Jan 9, 2026

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
main, 1.9, 1.8
Issue:
RHIDP-11225
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1669/scorecard-plugin/

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Jan 9, 2026

Copy link
Copy Markdown
Member

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabel-rh A few suggestions for your consideration. Please let me know if you have any questions.

Comment thread modules/observe/scorecards/con-understand-scorecard-plugins.adoc Outdated
Comment thread modules/observe/scorecards/ref-supported-metrics-providers.adoc Outdated
Comment thread modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc Outdated
Comment thread modules/observe/scorecards/con-manage-metric-thresholds-in-scorecard-plugin.adoc Outdated
Comment thread modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc Outdated
Copy link
Copy Markdown
Member

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabel-rh The content looks good overall, and I’ve added a few suggestions for your consideration.

One small observation from the preview: I noticed fourth- and fifth-level headings, which we generally try to avoid. It might be worth considering using a description list instead of additional heading levels.

image

Comment thread titles/scorecard-plugin/master.adoc Outdated
Comment thread assemblies/assembly-scorecards-rhdh.adoc
Comment thread modules/observe/scorecards/con-understand-scorecard-plugins.adoc Outdated
Comment thread modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc Outdated
Comment thread modules/observe/scorecards/proc-viewing-scorecards-in-rhdh.adoc Outdated
Copy link
Copy Markdown
Member

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment from my side — otherwise, everything looks good to me. 😊

Comment thread assemblies/assembly-scorecards-rhdh.adoc Outdated
@sonarqubecloud
Copy link
Copy Markdown

@pabel-rh pabel-rh dismissed dzemanov’s stale review January 29, 2026 05:07

Dominika has approved with a minor comment. I have incorporated her comment.

@deerskindoll deerskindoll merged commit f623972 into redhat-developer:main Jan 29, 2026
6 checks passed
@pabel-rh
Copy link
Copy Markdown
Member Author

/cherry-pick release-1.9

@pabel-rh
Copy link
Copy Markdown
Member Author

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@pabel-rh: #1669 failed to apply on top of branch "release-1.8":

Applying: Fixed merge conflict
Using index info to reconstruct a base tree...
M	modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
M	modules/observe/scorecards/con-how-thresholds-work.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/observe/scorecards/con-how-thresholds-work.adoc
Auto-merging modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
CONFLICT (content): Merge conflict in modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fixed merge conflict

Details

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@pabel-rh: new pull request created: #1725

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants