chore(snc): Refactor openshift-snc code#727
Merged
anjannath merged 2 commits intoredhat-developer:mainfrom Feb 18, 2026
Merged
Conversation
anjannath
reviewed
Feb 17, 2026
anjannath
reviewed
Feb 17, 2026
Collaborator
|
Tested and working fine, with |
Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
…onfig Previously we introduced the disable-cluster-readiness to allow early access to the cluster, within that commit we hide the kubeconfig export when the flag was enable, actually it can be exported no matter the value of the flag. This commit enables it. Fixes redhat-developer#719. Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
|
Quick comment to say that I was also able to run this image with |
anjannath
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will refactor the openshift-snc offering to prepare it for azure support. It also re enable the kubeconfig generation even with the
--disable-cluster-readinessflag enable.Fixes #719