Fix for javascript gamemaker extension files not being correctly copied when built #6
+131
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed when built GameMaker javascript extensions were not being correctly copied to the assets directory when the project was built in GameMaker. An assets manifest is now created during build, and processed by main.ts before the runner.js script is loaded A seperate change is needed in the GameMaker runtime to allow javascript extensions to function correctly, but can be patched locally in the meantime by replacing: `Da[a]=eval(a)` with `Da[a]=globalThis[a]` in the client/src/public/runner.js file once built
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GameMaker javascript extensions were not being correctly copied to the assets directory when the project was built in GameMaker.
An assets manifest is now created during build, and processed by main.ts before the runner.js script is loaded
A seperate change is needed in the GameMaker runtime to allow javascript extensions to function correctly, but can be patched locally in the meantime by replacing:
Da[a]=eval(a)withDa[a]=globalThis[a]in the client/src/public/runner.js file once built