fix: EnumCaseToPascalCaseRector bugs#7278
Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom Sep 15, 2025
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
from
e205535 to
70b25a3
Compare
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
from
70b25a3 to
5b75d94
Compare
Member
|
Looks good, thank you 👍 |
samsonasik
reviewed
Sep 15, 2025
|
|
||
| $enumClassName = $classConstFetch->class->toString(); | ||
| if (! $this->reflectionProvider->hasClass($enumClassName)) { | ||
| if ($this->isUsedOutsideOfProject($classConstFetch->class)) { |
Member
There was a problem hiding this comment.
self should can be recefenced to current classreflection name, if it is ThisType, should be utilze $type->getStaticObjectType() so can look up correct target name.
Contributor
Author
There was a problem hiding this comment.
self should can be recefenced to current classreflection name
If the rector is processing self then it should be guaranteed to be a path used in withPaths
Member
There was a problem hiding this comment.
Ok, let see it in the wild :),
/cc @marcelthole @boesing in case you have a chance to test latest "rector/rector": "dev-main" for EnumCaseToPascalCaseRector rule :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This fixes some more bugs in the rector:
selfwere not being renamedThanks!