[type-declaration-docblocks] Add AddParamArrayDocblockFromDimFetchAccessRector#7253
Merged
TomasVotruba merged 1 commit intomainfrom Sep 12, 2025
Merged
Conversation
e8f7f30 to
2a1295a
Compare
Member
|
It seems mostly got function foo(array $params, int $page, int $limit)
{
$params['page'] = $page;
$params['limit'] = $limit;
}got: +/**
+ * @param array<string, mixed> $params
+ */which I think should possibly: +/**
+ * @param array<string, int> $params
+ */ |
Member
Author
|
That doesn't have to be true, as |
Member
Author
|
Do you have some real-world file where this rule should be improved? More context would help |
Member
|
Yes, on our project 👍 , using blindly set to mixed will cause everything like mixed, while it on use is not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rules adds known
@paramdocblock for keys used in method body 👍final class ParamArray { + /** + * @param array<string, mixed> $data + */ public function process(array $data): void { $item = $data['key']; $anotherItem = $data['another_key']; } }