[CodeQuality] Skip return createMock() on TypeWillReturnCallableArrowFunctionRector #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba I tested in our project, this cause diff:
1) Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\TypeWillReturnCallableArrowFunctionRector\TypeWillReturnCallableArrowFunctionRectorTest::test with data set #3 ('/Users/samsonasik/www/rector-...hp.inc') Failed on fixture file "skip_return_create_mock.php.inc" Failed asserting that string matches format description. --- Expected +++ Actual @@ @@ $form = $this->createMock(FormInterface::class); $form->method('add') - ->willReturnCallback(function ($name, $type, $options) use (&$calls) { + ->willReturnCallback(function ($name, $type, $options) use (&$calls): static { $calls[] = compact('name', 'type', 'options'); return $this->createMock(FormInterface::class); });which cause error: