Use Int_ over deprecated LNumber

[samsonasik]

LNumber is deprecated, use Int_ instead, ref #510 (review)

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[TomasVotruba]

I wonder why PHPStan didn't pick it up

[samsonasik]

We have rector-php-parser repo for php-parser 4 to 5 migration, just not registered as extension

• https://github.com/rectorphp/rector-php-parser

see these config:

https://github.com/rectorphp/rector-php-parser/blob/0cfdb1c1f9bec91ba6dd60406405d9893ebd3153/config/sets/php-parser-50.php#L18-L19

if we use old class, it won't be supported by native Printer method, afaik, eg:

protected function pScalar_Int(Int_ $int): string

[TomasVotruba]

I mean phsptan deprecation rules, that pick up elements with @deprecated annotation and report them.

I see the class is not deprecated, rather hidden with magic :)

[samsonasik]

The @deprecated tag exists, see

https://github.com/nikic/PHP-Parser/blob/f103601b29efebd7ff4a1ca7b3eeea9e3336a2a2/lib/PhpParser/Node/Scalar/Int_.php#L81-L82

[TomasVotruba]

That's another magic not supported. PHPStan can pick up only annotation right above the class.

[samsonasik]

I may can see if I have a chance to create PR to nikic/php-parser to add @deprecated above the LNumber class and other flagged as @deprecated so PHPStan can pick it up.

[samsonasik]

nikic/PHP-Parser#1103