[PHPUnit12] Add AssertIsTypeMethodCallRector

[mttsch]

No description provided.

[mttsch]

After wanting to continue with the contains deprecations from https://github.com/sebastianbergmann/phpunit/blob/11.5/DEPRECATIONS.md#soft-deprecations, I am wondering whether to also consider them in this rector to have rector for "generic method with type parameter to specialized type-specific method" that covers isType, assertContainsOnly, assertNotContainsOnly and containsOnly (this rector would be renamed, of course). Otherwise I would add a separate AssertContainsMethodCallRector.

@samsonasik Do you have a preference?

[TomasVotruba]

I wonder if we can have another rule that would simply use exact assert method:

-$this->assertThat($value, $this->isType('null'));
+$this->assertNull($value);

E.g. in phpunit code quality set. Much more readable and direct.

[mttsch]

I get your point but for this specific rector rule fixture, it makes sense to keep it like this to keep the fixture code somewhat "useful" instead of just calling the relevant methods and doing nothing with the return type.

Also see PHPUnit's test cases for these methods which are the exact same https://github.com/sebastianbergmann/phpunit/blob/a561bbf7dd850c1bef4f8db7230ffa68ca6797af/tests/unit/Framework/Assert/assertThatTest.php#L423-L426

But I guess you are talking more about a different rule from this one.

[TomasVotruba]

Yes, this is job for next Rector rule :)

[TomasVotruba]

@mttsch I forgot to merge this. Fixing that.
Thank you 👍