Cover array shape iterator for YieldDataProviderRector+RemoveUselessReturnTagRector. #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
could you fix rectify: |
biozshock
force-pushed
the
issue-invalid-key
branch
from
424e83a to
80d3ba2
Compare
Contributor
Author
|
There's a rector change in the other part of the code. Should it be fixed here, or in a separate PR? |
Member
|
Run here seems fine as only single file |
Member
|
Test seems green |
Contributor
Author
|
Well, yes, but you can check the phpunit output :). |
…or-phpunit into issue-invalid-key
Member
|
The issue seems on rector-src on |
Member
|
I pushed empty commit to trigger latest rector-src 55220b8 👍 |
Member
|
@biozshock All green 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to identify the issue.
As far as i was able to debug the issue is actually in the doc parsing in the phpstan.
In this case the
$varianceshere is an empty array.Though the PHPStan itself processes the "before" and "after" correctly.