Skip to content

[AnnotationsToAttributes] Apply to class level on @uses on AnnotationWithValueToAttributeRector #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 5 commits into from
May 20, 2025
Merged

[AnnotationsToAttributes] Apply to class level on @uses on AnnotationWithValueToAttributeRector #492

samsonasik merged 5 commits into from
May 20, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented May 20, 2025

Make rule configurable to apply on class level.

Fixes rectorphp/rector#9178

@samsonasik
Copy link
Member Author

samsonasik commented May 20, 2025

Fixed 🎉 /cc @staabm

@samsonasik samsonasik mentioned this pull request May 20, 2025
Closed
@samsonasik
Copy link
Member Author

samsonasik commented May 20, 2025

All checks have passed 🎉 @TomasVotruba it is ready for review.

staabm
staabm reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix. I think we need the same behaviour on UsesFunction annotation which also is only supported on class-level

https://github.com/sebastianbergmann/phpunit/blob/6dbcca2e8c33ffe66182ad586572f22702b47967/src/Framework/Attributes/UsesFunction.php#L19

@samsonasik
Copy link
Member Author

samsonasik commented May 20, 2025

@staabm we don't have UsesFunction registered in config yet, so I think different PR is better for that case once this PR merged

@samsonasik samsonasik merged commit 6cad71e into main May 20, 2025
6 checks passed
@samsonasik samsonasik deleted the add-class-level branch May 20, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

+1 more reviewer

@staabm staabm staabm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

phpunit @uses transformed into method level attribute

4 participants

@samsonasik @staabm @TomasVotruba