Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented May 20, 2025

  • add phpunit 12 rule to remove __construct as already final
  • use attribute flag hasRemovedFinalConstruct so in rule ParentTestClassConstructorRector can be checked to avoid flip flop change when both rules accidentally registered.
  • Register missing phpunit 11 rule on config.

Fixes Closes rectorphp/rector#9180

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @Jean85

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit b95bf5a into main May 20, 2025
6 checks passed
@TomasVotruba TomasVotruba deleted the add-remove-over branch May 20, 2025 15:39
@TomasVotruba
Copy link
Member

Looks good, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ParentTestClassConstructorRector does not consider final constructor

3 participants