Fix RemoveNamedArgsInDataProviderRector so that it is not applied if no change is made #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-granados
force-pushed
the
fix-RemoveNamedArgsInDataProviderRector
branch
2 times, most recently
from
2b6e944 to
979f955
Compare
samsonasik
reviewed
Apr 1, 2025
...ss_/RemoveNamedArgsInDataProviderRector/Fixture/skip_provide_data_with_no_named_args.php.inc
Outdated
Show resolved
Hide resolved
…no change is made
carlos-granados
force-pushed
the
fix-RemoveNamedArgsInDataProviderRector
branch
from
979f955 to
ba5efac
Compare
Member
|
Thank you @carlos-granados |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the name of the fixture file to name it
skip_...and changes it so that the changed part is removed as no change is expectedI also changed the name of the
handleStmtfunction as that function was not handling a statement, instead it was handling anArray_node