Skip to content

[Attribute] Fix typo RequiresExtension -> RequiresPhpExtension on RequiresAnnotationWithValueToAttributeRector #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Mar 3, 2025
Merged

[Attribute] Fix typo RequiresExtension -> RequiresPhpExtension on RequiresAnnotationWithValueToAttributeRector #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ctor/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_fixture.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ use PHPUnit\Framework\TestCase;
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
class BarController extends TestCase
{
Expand All @@ -54,8 +54,8 @@ class BarController extends TestCase
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
public function testWithRequires()
{
Expand Down
10 changes: 5 additions & 5 deletions rules/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ public function test()
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
final class SomeTest extends TestCase
{
Expand All @@ -95,8 +95,8 @@ final class SomeTest extends TestCase
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
public function test()
{
Expand Down Expand Up @@ -194,7 +194,7 @@ private function createAttributeGroup(string $annotationValue): ?AttributeGroup

break;
case 'extension':
$attributeClass = 'PHPUnit\Framework\Attributes\RequiresExtension';
$attributeClass = 'PHPUnit\Framework\Attributes\RequiresPhpExtension';
$attributeValue = explode(' ', (string) $attributeValue, 2);
break;
case 'setting':
Expand Down
8 changes: 4 additions & 4 deletions tests/AnnotationsToAttributes/Fixture/requires_fixture.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ use PHPUnit\Framework\TestCase;
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
class BarController extends TestCase
{
Expand All @@ -54,8 +54,8 @@ class BarController extends TestCase
#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
#[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
#[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
#[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
public function testWithRequires()
{
Expand Down
Loading