[CodeQuality] Skip loose comparison on assertNotEquals as well on AssertEqualsToSameRector #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertEqualsToSameRector
…ertEqualsToSameRector
| { | ||
| $this->assertNotEquals(1, $float); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This should be covered a separate rule that would update both name and type.
-$this->assertNotEquals(1, $float);
+$this->assertNotSame(1.0, $float);
Member
Author
There was a problem hiding this comment.
loose comparison needs to be verified manually, eg int vs float, it can be true while on assertSame it be false, on opposite, it happen as well, make always not same, which actually can be equal
Member
Author
There was a problem hiding this comment.
Oh, I see what you mean, that's value need to be changed, however, that's need to be checked as constant value, otherwise, cast (float)/(int) may be needed
Member
There was a problem hiding this comment.
Yes, it should be applied on constant int/float values only. I always handle this change manually, often ~100s of cases and it's such a pain :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.