Re-skip Override and SensitiveParameter #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems cause invalid test on combine with |
Member
Author
|
Let's try add new line before for param. |
Member
Author
|
It seems still issue https://github.com/rectorphp/rector-src/actions/runs/17532914306/job/49825764897#step:14:73 It probably due to php-scoper printing it to be new line on parameters, so reverting again... |
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
This reverts commit 57f45d4.
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
This reverts commit 57f45d4.
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
samsonasik
added a commit
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kkmuffme let's try using reprint instead of token based add new line for this, since downgraded code is applied with php-scoper that may cause param printed in new line again.