Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/ComposerProcessor/OpenVersionsComposerProcessor.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ public function process(
foreach ($outdatedPackages as $outdatedPackage) {
$composerVersion = $outdatedPackage->getComposerVersion();

// already filled with open version
if (str_contains($composerVersion, '|')) {
if ($this->skipExistingVersion($composerVersion)) {
continue;
}

Expand Down Expand Up @@ -64,4 +63,14 @@ public function process(

return new ChangedPackageVersionsResult($composerJsonContents, $openedPackages);
}

private function skipExistingVersion(string $composerVersion): bool
{
// already filled with open version
if (str_contains($composerVersion, '|')) {
return true;
}

return str_contains($composerVersion, 'dev-');
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"require": {
"symfony/console": "dev-test"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,23 @@ public function test(): void
$changedPackageVersionsResult->getComposerJsonContents()
);
}

public function testSkipDev(): void
{
$composerJsonContents = FileSystem::read(__DIR__ . '/Fixture/skip-dev.json');

$outdatedComposer = new OutdatedComposer([
new OutdatedPackage('symfony/console', '5.4.0', 'dev-main', true, '6.4.0', '1 year'),
]);

$changedPackageVersionsResult = $this->openVersionsComposerProcessor->process(
$composerJsonContents,
$outdatedComposer,
10,
false,
null
);

$this->assertEmpty($changedPackageVersionsResult->getChangedPackageVersions());
}
}