Skip to content

Conversation

@Yoann-TYT
Copy link

Hi Everyone !

This PR removes a section of the documentation that referred to a rule now deprecated since this PR.
As the rule no longer works, it doesn’t make sense to keep it documented.

I’d also like to thank the Rector community for everything they bring to the PHP ecosystem — truly impressive work.
I found the arguments for moving from YAML to PHP configuration very compelling, and I'm sad that this approach is no longer supported.

@TomasVotruba
Copy link
Member

Hey,

this is a different topic. The Rector rules is related to Symfony 5.3 feature by Tobias Nyholm: https://symfony.com/blog/new-in-symfony-5-3-config-builder-classes

The config-transformer handles YAML to PHP array-like configuration: https://tomasvotruba.com/blog/2020/07/27/how-to-switch-from-yaml-xml-configs-to-php-today-with-migrify

They both have "PHP" keywords, but it's a different feature. More confusion will come with news PHP-arrays config format :)

@Yoann-TYT
Copy link
Author

Thanks for the clarification, @TomasVotruba ! that makes perfect sense.
You’re right, the original line mixed two different things.

I can open a new PR with a clearer version like this :

There is also symplify/config-transformer that helps with transforming YAML or XML Symfony configs into PHP array-based configuration files.

Note: The Rector rule StringExtensionToConfigBuilderRector, which converted YAML configs into Symfony Config Builder classes, has been deprecated, since the fluent PHP configuration format is no longer recommended in Symfony.

That should clarify the intent while keeping the useful reference to config-transformer.

@TomasVotruba
Copy link
Member

No worries 👍

That would suggest they're related, which is not true.

Symfony docs should make more clear which is which. That's the root source of knowledge for Symfony devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants