Skip to content

Conversation

@samsonasik
Copy link
Member

Avoid error undefined theme javascript error, as only when codeMirror is set.

[localhost:8000:56:22](http://localhost:8000/)
Uncaught TypeError: theme is null
    toggleTheme http://localhost:8000/:72
    onclick http://localhost:8000/:1

@samsonasik samsonasik enabled auto-merge (squash) April 30, 2025 15:18
@samsonasik samsonasik merged commit 65bfa45 into main Apr 30, 2025
7 checks passed
@samsonasik samsonasik deleted the only-show-toggle branch April 30, 2025 15:18
@samsonasik
Copy link
Member Author

Fixed and deployed 👍

@TomasVotruba
Copy link
Member

This should be available on any page, so people are not confused by disappearing option.

Independent on code mirror itself.

@samsonasik
Copy link
Member Author

Then it seems variable id "theme-link" exists seems needed to avoid error:

[localhost:8000:56:22](http://localhost:8000/)
Uncaught TypeError: theme is null
    toggleTheme http://localhost:8000/:72
    onclick http://localhost:8000/:1

@samsonasik
Copy link
Member Author

@TomasVotruba I created PR :

to re-add it while avoid error Uncaught TypeError: theme is null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants