Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Apr 14, 2025

Current solution uses position: absolute that disallows clearing div. That's why code overflows to next element.

The only path nows seems spliiting into 2 columns: one with origin code and 2nd with diffs.

Screenshot From 2025-04-14 15-50-12

Closes #2957

@TomasVotruba TomasVotruba changed the title tv block [demo] Split code and diffs into 2 separate columns to avoid overflow Apr 14, 2025
@samsonasik
Copy link
Member

It seems on default example, it cause splitted right bottom

Screenshot 2025-04-15 at 18 02 39

@TomasVotruba
Copy link
Member Author

@samsonasik I'll check it, thanks for testing 👍

@TomasVotruba TomasVotruba requested a review from samsonasik April 15, 2025 11:42
@TomasVotruba
Copy link
Member Author

It seems it's a dead end - either we break diff positions, or the diff overflows to text.


I came up with a creative solution, to tidy up buttons under text - there should be 1 button a page anyway 🤗

It looks pretty cool: there is section on the left with all details and actions, and right is space for diffs.

Before 🧓

Screenshot From 2025-04-15 16-05-35


After :party:

Screenshot From 2025-04-15 16-05-03

@TomasVotruba TomasVotruba merged commit 79ee475 into main Apr 15, 2025
7 checks passed
@TomasVotruba TomasVotruba deleted the tv-block branch April 15, 2025 14:13
@TomasVotruba TomasVotruba mentioned this pull request Apr 15, 2025
@samsonasik
Copy link
Member

It seems "Add a test fixture" link is not shown on default example

Screenshot 2025-04-15 at 21 17 17

@samsonasik
Copy link
Member

Oh I see, create a fixture only doable on 1 rule applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Demo UI broken

3 participants