Skip to content

Fix documentation level, it start from 0 #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Dec 30, 2024
Merged

Fix documentation level, it start from 0 #2784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions resources/docs/levels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ We took the liberty of sorting the rules from the easy-pick to more complex ones
return RectorConfig::configure()
->withPaths([__DIR__ . '/src', __DIR__ . '/tests'])
- ->withPreparedSets(typeDeclaration: true);
+ ->withTypeCoverageLevel(1);
+ ->withTypeCoverageLevel(0);
```

Now run Rector to see the changed files:
Expand All @@ -51,7 +51,7 @@ Now run Rector to see the changed files:
vendor/bin/rector
```

Only five files? We can do that in a day. We create a pull request, get a review, and merge. The next day, we can continue with level 2. You get the idea.
Only five files? We can do that in a day. We create a pull request, get a review, and merge. The next day, we can continue with level 1. You get the idea.

## Dead Code and Code Quality Level

Expand All @@ -66,9 +66,9 @@ use Rector\Config\RectorConfig;

return RectorConfig::configure()
->withPaths([__DIR__ . '/src', __DIR__ . '/tests'])
->withTypeCoverageLevel(1)
->withDeadCodeLevel(1)
->withCodeQualityLevel(1);
->withTypeCoverageLevel(0)
->withDeadCodeLevel(0)
->withCodeQualityLevel(0);
```

We increase it by 1, run Rector, create a pull request, get a review, and merge.
Expand Down
Loading