Tracks naming fix and minor UI improvements #2480
Open
+86
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
phisher98
changed the title
fire-light42
approved these changes
Feb 11, 2026
okibcn
reviewed
Feb 11, 2026
| else -> m.uppercase() | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Have you thought about adding the audio channel configuration (Mono, Stereo, 5.1, ...) to the player info?
okibcn
reviewed
Feb 11, 2026
| when { | ||
| mime.contains("eac3-joc") -> "Dolby Atmos" | ||
| mime.contains("eac3") -> "E-AC3" | ||
| mime.contains("ac-3") || mime.contains("ac3") -> "AC3" |
Contributor
There was a problem hiding this comment.
Nice catch!!!!! Having ac3 before the others was preventing eac3 or eac3-joc from being properly detected.
Looking forward to seeing this PR merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Video Codec Minor Fix (adding case insensitive) and More UI Fixes