Skip to content

Fix false positives in vertical_parameter_alignment_on_call with Unicode#6535

Open
theamodhshetty wants to merge 1 commit intorealm:mainfrom
theamodhshetty:codex/fix-vertical-parameter-alignment-unicode
Open

Fix false positives in vertical_parameter_alignment_on_call with Unicode#6535
theamodhshetty wants to merge 1 commit intorealm:mainfrom
theamodhshetty:codex/fix-vertical-parameter-alignment-unicode

Conversation

@theamodhshetty
Copy link
Contributor

Summary

  • compare argument alignment using character columns instead of raw UTF-8 columns
  • add a regression example for a call whose first line contains a multi-byte character before the argument list
  • update the changelog

Fixes #6467.

Testing

  • swift test --filter VerticalParameterAlignmentOnCallRuleGeneratedTests
  • ./.build/debug/swiftlint lint Source/SwiftLintBuiltInRules/Rules/Style/VerticalParameterAlignmentOnCallRule.swift CHANGELOG.md --strict

@SwiftLintBot
Copy link

22 Messages
📖 Building this branch resulted in a binary size of 27357.95 KiB vs 27357.74 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.2 s vs 0.21 s on main (4% faster).
📖 Linting Alamofire with this PR took 0.34 s vs 0.24 s on main (41% slower).
📖 Linting Brave with this PR took 4.94 s vs 0.86 s on main (474% slower).
📖 Linting DuckDuckGo with this PR took 6.48 s vs 3.41 s on main (90% slower).
📖 Linting Firefox with this PR took 5.47 s vs 1.58 s on main (246% slower).
📖 Linting Kickstarter with this PR took 17.24 s vs 0.99 s on main (1641% slower).
📖 Linting Moya with this PR took 0.18 s vs 0.12 s on main (50% slower).
📖 Linting NetNewsWire with this PR took 0.42 s vs 0.37 s on main (13% slower).
📖 Linting Nimble with this PR took 0.17 s vs 0.2 s on main (15% faster).
📖 Linting PocketCasts with this PR took 4.26 s vs 0.96 s on main (343% slower).
📖 Linting Quick with this PR took 0.18 s vs 0.16 s on main (12% slower).
📖 Linting Realm with this PR took 11.0 s vs 0.45 s on main (2344% slower).
📖 Linting Sourcery with this PR took 0.62 s vs 0.33 s on main (87% slower).
📖 Linting Swift with this PR took 1.29 s vs 0.55 s on main (134% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 3.87 s vs 3.87 s on main (0% slower).
📖 Linting VLC with this PR took 0.35 s vs 0.26 s on main (34% slower).
📖 Linting Wire with this PR took 21.24 s vs 2.04 s on main (941% slower).
📖 Linting WordPress with this PR took 1.7 s vs 1.42 s on main (19% slower).
📖 This PR fixed a violation in DuckDuckGo: /macOS/DuckDuckGo/Preferences/View/PreferencesAboutView.swift:272:37: Warning: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/AddressBarTextField.swift:1068:45: Warning: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/AddressBarTextField.swift:1069:45: Warning: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive in rule vertical_parameter_alignment_on_call

2 participants