fix: cast integer values to string before rawurlencode in query string builder#36
Merged
pkotets merged 1 commit intoreaddle:masterfrom Mar 16, 2026
Conversation
pkotets
approved these changes
Mar 16, 2026
Collaborator
|
Thanks a lot for the fix, and especially for the test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rawurlencode() type error on integer query parameters
Fixes #34
Problem
When building a query string, integer values were passed directly to rawurlencode(), which expects a string. This caused a fatal error:
rawurlencode(): Argument #1 ($string) must be of type string, int givenFor example, GetTransactionHistoryQueryParams defines startDate and endDate as int (Unix timestamps). Passing them to getQueryString() triggered the error:
Solution
Added an explicit is_int check in AbstractRequestQueryParams::getQueryString() so integer values are appended directly without going through rawurlencode(), consistent with how booleans are already handled.
Changes