[MASTER] Add x86 and x64 builders/testers for -DSAFE_TESTS_ONLY=1#11
Open
ColinFinck wants to merge 7 commits intomasterfrom
Open
[MASTER] Add x86 and x64 builders/testers for -DSAFE_TESTS_ONLY=1#11ColinFinck wants to merge 7 commits intomasterfrom
-DSAFE_TESTS_ONLY=1#11ColinFinck wants to merge 7 commits intomasterfrom
Conversation
This is what we have the repo history for.
Member
Author
tkreuzer
approved these changes
Sep 19, 2023
tkreuzer
left a comment
There was a problem hiding this comment.
I cannot really judge the code, but I like to have this thing. So approved.
ColinFinck
added a commit
that referenced
this pull request
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @tkreuzer, here comes an extra tester for a rostests build with
-DSAFE_TESTS_ONLY=1.This allows @tkreuzer to implement a list of safe tests in the main repo and only run these (without crash recovery).
Next to the testers, I needed to add an extra builder for x86 and x64.
This is necessary, because:
I took the opportunity to clean up our BuildBot master.cfg, deduplicate lots of copy-pastes, and remove commented out and long obsoleted configs.
Therefore, this PR is best to be reviewed commit by commit.