feat: Links in markdown when serving .md files #8274
+55
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be seen a as nice to have, but when serving markdown, the links in the content should also have
.mdin the pathname.For example https://docs.stripe.com/testing.md lists some
.mdlinks. In react.dev docs markdown pages, this would looke like,/learn/your-first-component.mdI guess, we should make those absolute too... this PR doesnt' do that currently. We'd just need to tweak the
NOOP_ORIGINlogic.I am also adding this check:
Without, locally in
devorbuild+start, I can make a request to:curl "http://localhost:3000/api/md/..%2F..%2FCONTRIBUTING"and get the root CONTRIBUTING.md document - only.mdfiles are affected, and the deployed version is protected by Vercel.