fix: cascade deletion removes parent and cleans up grandparent refs in TravelPlan useImmer example#8144
Open
DeveloperViraj wants to merge 2 commits intoreactjs:mainfrom
Open
Conversation
…bility and presets
…n TravelPlan useImmer example
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes the TravelPlan example in “Choosing the State Structure” so that deleting a place now behaves correctly and cleans up all related data.
When the last child of a node is removed, the example now:
Removes the entire subtree of that child (for proper memory cleanup)
Removes the deleted node’s ID from its parent’s childIds
Automatically deletes the parent if it becomes empty (and isn’t the root)
Removes that parent’s ID from its own parent, cascading the cleanup upward until the root
This prevents dangling references and ensures that deletions cascade cleanly through the hierarchy.
Changed file:
src/content/learn/choosing-the-state-structure.md
Notes:
The root node (ID 0) is always preserved.
The logic uses concise use-immer draft updates for clarity and immutability.