Update act() usage to be async in examples#8142
Open
valgaze wants to merge 1 commit intoreactjs:mainfrom
Open
Conversation
The second example uses a synchronous callback to act(), but the docs recommend always using the async version and mention the sync form will be deprecated. This PR updates the example so the callback is async for consistency with current React recommendations.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This 🐣 PR updates the second example on react.dev/reference/react/act to use an async callback with
act()+ fix an alignment issue with another sampleAlthough the example currently uses a synchronous callback, the documentation below it explicitly recommends always using the async form:
Updating the example to use an async callback makes it consistent with:
This change does not alter the behavior of the example, but aligns it with the recommended best practice and helps avoid confusion for readers.