refactor(Sprockets) extract sprockets mount; use silence_deprecations for 3.7+

Author: rmosolgo

lib/react/jsx.rb

@@ -3,6 +3,7 @@
 require 'react/jsx/template'
 require 'react/jsx/jsx_transformer'
 require 'react/jsx/babel_transformer'
+require 'react/jsx/sprockets_strategy'
 require 'rails'
 
 module React

lib/react/jsx/sprockets_strategy.rb

@@ -0,0 +1,53 @@
+module React
+  module JSX
+    # Depending on the Sprockets version,
+    # attach JSX transformation the the Sprockets environment.
+    #
+    # You can override it with `config.sprockets_strategy`
+    # @example Specifying a Sprockets strategy
+    #   app.config.react.sprockets_strategy = :register_engine
+    #
+    # @example Opting out of any Sprockets strategy
+    #   app.config.react.sprockets_strategy = false
+    #
+    module SprocketsStrategy
+      module_function
+
+      # @param [Sprockets::Environment] the environment to attach JSX to
+      # @param [Symbol, Nil] A strategy name, or `nil` to detect a strategy
+      def attach_with_strategy(sprockets_env, strategy_or_nil)
+        strategy = strategy_or_nil || detect_strategy
+        self.public_send(strategy, sprockets_env)
+      end
+
+      # @return [Symbol] based on the environment, return a method name to call with the sprockets environment
+      def detect_strategy
+        sprockets_version = Gem::Version.new(Sprockets::VERSION)
+        if sprockets_version >= Gem::Version.new("4.0.0")
+          :register_processors
+        elsif sprockets_version >= Gem::Version.new("3.0.0")
+          :register_engine_with_mime_type
+        else
+          :register_engine
+        end
+      end
+
+      def register_engine(sprockets_env)
+        sprockets_env.register_engine(".jsx", React::JSX::Template)
+      end
+
+      def register_engine_with_mime_type(sprockets_env)
+        sprockets_env.register_engine(".jsx", React::JSX::Processor, mime_type: "application/javascript", silence_deprecation: true)
+      end
+
+      def register_processors(sprockets_env)
+        sprockets_env.register_mime_type("application/jsx", extensions: [".jsx", ".js.jsx", ".es.jsx", ".es6.jsx"])
+        sprockets_env.register_mime_type("application/jsx+coffee", extensions: [".jsx.coffee", ".js.jsx.coffee"])
+        sprockets_env.register_transformer("application/jsx", "application/javascript", React::JSX::Processor)
+        sprockets_env.register_transformer("application/jsx+coffee", "application/jsx", Sprockets::CoffeeScriptProcessor)
+        sprockets_env.register_preprocessor("application/jsx", Sprockets::DirectiveProcessor.new(comments: ["//", ["/*", "*/"]]))
+        sprockets_env.register_preprocessor("application/jsx+coffee", Sprockets::DirectiveProcessor.new(comments: ["#", ["###", "###"]]))
+      end
+    end
+  end
+end

lib/react/rails/railtie.rb

@@ -10,6 +10,7 @@ class Railtie < ::Rails::Railtie
       config.react.jsx_transform_options = {}
       config.react.jsx_transformer_class = nil # defaults to BabelTransformer
       config.react.camelize_props = false # pass in an underscored hash but get a camelized hash
+      config.react.sprockets_strategy = nil # how to attach JSX to the asset pipeline (or `false` for none)
 
       # Server rendering:
       config.react.server_renderer_pool_size  = 1   # increase if you're on JRuby
@@ -97,22 +98,13 @@ class Railtie < ::Rails::Railtie
       end
 
       initializer "react_rails.setup_engine", :group => :all do |app|
-        # Sprockets 3.x expects this in a different place
-        sprockets_env = app.assets || defined?(Sprockets) && Sprockets
+        if app.config.react.sprockets_strategy == false
+          # pass, sprockets opt-out
+        else
+          # Sprockets 3.x expects this in a different place
+          sprockets_env = app.assets || defined?(Sprockets) && Sprockets
 
-        if !sprockets_env.nil?
-          if Gem::Version.new(Sprockets::VERSION) >= Gem::Version.new("3.7.0")
-            sprockets_env.register_mime_type("application/jsx", extensions: [".jsx", ".js.jsx", ".es.jsx", ".es6.jsx"])
-            sprockets_env.register_mime_type("application/jsx+coffee", extensions: [".jsx.coffee", ".js.jsx.coffee"])
-            sprockets_env.register_transformer("application/jsx", "application/javascript", React::JSX::Processor)
-            sprockets_env.register_transformer("application/jsx+coffee", "application/jsx", Sprockets::CoffeeScriptProcessor)
-            sprockets_env.register_preprocessor("application/jsx", Sprockets::DirectiveProcessor.new(comments: ["//", ["/*", "*/"]]))
-            sprockets_env.register_preprocessor("application/jsx+coffee", Sprockets::DirectiveProcessor.new(comments: ["#", ["###", "###"]]))
-          elsif Gem::Version.new(Sprockets::VERSION) >= Gem::Version.new("3.0.0")
-            sprockets_env.register_engine(".jsx", React::JSX::Processor, mime_type: "application/javascript")
-          else
-            sprockets_env.register_engine(".jsx", React::JSX::Template)
-          end
+          React::JSX::SprocketsStrategy.attach_with_strategy(sprockets_env, app.config.react.sprockets_strategy)
         end
       end
     end