test requiring .js and .coffee from .jsx

Author: rmosolgo

test/dummy/app/assets/javascripts/require_test/jsx_preprocessor_test.jsx

@@ -1,3 +1,4 @@
+//= require ./jsx_require_child_jsx
 //= require ./jsx_require_child_js
+//= require ./jsx_require_child_coffee
 <div className="le-javascript" />
-

test/dummy/app/assets/javascripts/require_test/jsx_require_child_coffee.coffee

@@ -0,0 +1 @@
+requireCoffee = true

test/dummy/app/assets/javascripts/require_test/jsx_require_child_js.js

@@ -0,0 +1 @@
+var requirePlainJavascript = true;

test/dummy/app/assets/javascripts/require_test/jsx_require_child_js.jsx

@@ -0,0 +1 @@
+<div className="require-jsx" />

test/dummy/app/assets/javascripts/require_test/jsx_require_child_jsx.jsx

@@ -1,16 +1,18 @@
 require 'test_helper'
 
 when_sprockets_available do
-  class JSXPreprocessorTest < ActionDispatch::IntegrationTest
-    EXPECTED_JS = <<javascript
-React.createElement(\"div\", { className: \"le-javascript-child\" });
-React.createElement(\"div\", { className: \"le-javascript\" });
-javascript
-
+  class JSXPreprocessorTest < ActiveSupport::TestCase
+    REQUIRED_JAVASCRIPT = "var requirePlainJavascript = true;"
+    REQUIRED_COFFEESCRIPT =  "var requireCoffee; requireCoffee = true;"
+    REQUIRED_JSX = "React.createElement(\"div\", { className: \"require-jsx\" });"
+    OWN_JSX = "React.createElement(\"div\", { className: \"le-javascript\" });"
     test 'executes //= require directives' do
-      get '/assets/require_test/jsx_preprocessor_test.js'
-      assert_response :success
-      assert_compiled_javascript_matches(@response.body, EXPECTED_JS)
+      require_parent = fetch_asset_body("require_test/jsx_preprocessor_test.js")
+
+      assert_compiled_javascript_includes(require_parent, REQUIRED_JAVASCRIPT)
+      assert_compiled_javascript_includes(require_parent, REQUIRED_COFFEESCRIPT)
+      assert_compiled_javascript_includes(require_parent, REQUIRED_JSX)
+      assert_compiled_javascript_includes(require_parent, OWN_JSX)
     end
   end
 end

test/react/jsx/jsx_prepocessor_test.rb

@@ -114,13 +114,18 @@ def when_sprockets_available
   end
 end
 
-class ActionDispatch::IntegrationTest
+def fetch_asset_body(asset_logical_path)
+  Rails.application.assets[asset_logical_path].to_s
+end
 
 # Different processors may generate slightly different outputs,
 # as some version inserts an extra "\n" at the beginning.
 # Because appraisal is used, multiple versions of coffee-script are treated
 # together. Remove all spaces to make test pass.
-  def assert_compiled_javascript_matches(javascript, expectation)
-    assert_equal expectation.gsub(/\s/, ''), javascript.gsub(/\s/, '')
-  end
-end
+def assert_compiled_javascript_matches(javascript, expectation)
+  assert_equal expectation.gsub(/\s/, ''), javascript.gsub(/\s/, '')
+end
+
+def assert_compiled_javascript_includes(javascript, expected_part)
+  assert_includes javascript.gsub(/\s/, ''), expected_part.gsub(/\s/, '')
+end