Split ObservableListEx.cs into per-family partial classes#1096
Open
dwcullop wants to merge 3 commits into
Open
Split ObservableListEx.cs into per-family partial classes#1096dwcullop wants to merge 3 commits into
dwcullop wants to merge 3 commits into
Conversation
Splits the 2900-line ObservableListEx.cs into 17 smaller partial-class files grouped by operator family. Each method (and all of its overloads) lives in exactly one file. The class declaration is changed to partial; no code, comments, or XML documentation is added, removed, or otherwise modified. All 2218 tests pass.
Renames ObservableListEx.Pagination.cs to ObservableListEx.Virtualise.cs for closer parity with the cache equivalent (ObservableCacheEx.VirtualiseAndPage.cs). Sorts members alphabetically within each new partial file; overloads of the same name preserve their original declaration order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
ObservableListEx.cs(2,929 lines, 63 distinct operator names spanning 128 method bodies) into 17 partial-class files grouped by operator family.This is a pure file reorganisation. The only code change is converting
public static class ObservableListExtopublic static partial class ObservableListEx. No method bodies, XML documentation, comments, preprocessor directives, or other content were added, removed, or altered. The byte content of every method body is preserved. Members within each file are alphabetised; overloads of the same name preserve their original declaration order. All UTF-8 BOM with CRLF line endings.New files
Numbers in parentheses indicate the count of overloads.
Deleted
src/DynamicData/List/ObservableListEx.csVerification
The split was generated programmatically with byte-level per-method equality checks against the original. Every public method and the 5 private static
Combineoverloads used internally by the combinator operators were confirmed to be present in exactly one file. The full test suite passes.