Add devcontainer configuration#1344
Add devcontainer configuration#1344JamesHutchison wants to merge 7 commits intoreactive-python:mainfrom
Conversation
Add launch and settings for workspace
JamesHutchison
left a comment
JamesHutchison
left a comment
There was a problem hiding this comment.
I need to clean this up and do a clean rebuild.
One consideration is that I don't see a way to spawn a test server that you can easily tweak. I have a non-committed main.py. It would be a better practice if someone could just grab a launch config and start a server that they can hand test (in my case, I was testing that disabling javascript indeed shows the noscript page)
.devcontainer/devcontainer.json
Outdated
| // "remoteUser": "vscode", | ||
| // "containerEnv": { | ||
| // "BUN_INSTALL": "/home/vscode/.bun" | ||
| // }, | ||
| // "remoteEnv": { | ||
| // "BUN_INSTALL": "/home/vscode/.bun", | ||
| // "PATH": "/home/vscode/.bun/bin:${containerEnv:PATH}" | ||
| // }, |
There was a problem hiding this comment.
need to remove
.devcontainer/devcontainer.json
Outdated
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
| "charliermarsh.ruff", | ||
| "ms-playwright.playwright" |
There was a problem hiding this comment.
extensions were plugged in with AI and should be updated to respect a sane workflow. No idea what this playwright extension is.
|
|
||
| # --- IDE --- | ||
| .idea | ||
| .vscode |
There was a problem hiding this comment.
While the .idea folder is intended to be private to a user, this is not the case for .vscode which is intended to be a workspace specific configuration.
1 participant
Description
Adds a developer container configuration and updates all references to Python 3.9 to 3.11
Checklist
Please update this checklist as you complete each item:
Tests have been developed for bug fixes or new functionality.The changelog has been updated, if necessary.Documentation has been updated, if necessary.GitHub Issues closed by this PR have been linked.By submitting this pull request I agree that all contributions comply with this project's open source license(s).
This addresses #597 which was closed a while back.