Skip to content

Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
+5 −4
Closed

Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes #57212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,15 +843,16 @@ TEST_F(BridgingTest, asyncArrayBufferBorrowThrowsOnJsHeapTest) {
}

TEST_F(BridgingTest, asyncArrayBufferBorrowNativeBackedTest) {
// Native-backed buffer: borrow succeeds, zero-copy. Only meaningful on
// runtimes that implement tryGetMutableBuffer.
// Native-backed buffer: borrow succeeds zero-copy on runtimes that implement
// tryGetMutableBuffer; otherwise borrow throws (since there is no native
// MutableBuffer to hand back).
auto nativeBuf =
std::make_shared<detail::OwnedBytesBuffer>(std::vector<uint8_t>{5, 6, 7});
auto* rawPtr = nativeBuf.get();
auto jsBuf = jsi::ArrayBuffer(rt, nativeBuf);
if (jsBuf.tryGetMutableBuffer(rt) == nullptr) {
GTEST_SKIP()
<< "Runtime does not expose tryGetMutableBuffer; borrow always throws";
EXPECT_JSI_THROW(AsyncArrayBuffer::borrow(rt, jsBuf));
return;
}
auto safe = AsyncArrayBuffer::borrow(rt, jsBuf);
EXPECT_EQ(3, safe.size());
Expand Down
Loading