Localize keyboard return-key labels on numeric-keypad input accessory view#57168
Open
cipolleschi wants to merge 1 commit into
Open
Localize keyboard return-key labels on numeric-keypad input accessory view#57168cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
… view Summary: The "Next", "Done", and other return-key button labels on the iOS numeric-keypad input accessory view render in English regardless of device locale. Root cause: `returnKeyTypeToString:` in `RCTTextInputComponentView.mm` returns hardcoded English string literals. These strings are passed directly to `UIBarButtonItem` as the button title, so they never go through the localization pipeline. Fix: Wrap each literal in the `RCTLocalizedString` macro, which registers the strings for translation. This follows the established React Native pattern used elsewhere in the codebase. Changelog: [iOS][Changed] - Adds localization for Text Input default return key types Differential Revision: D108270298
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108270298. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The "Next", "Done", and other return-key button labels on the iOS numeric-keypad input accessory view render in English regardless of device locale.
Root cause:
returnKeyTypeToString:inRCTTextInputComponentView.mmreturns hardcoded English string literals. These strings are passed directly toUIBarButtonItemas the button title, so they never go through the localization pipeline.Fix: Wrap each literal in the
RCTLocalizedStringmacro, which registers the strings for translation. This follows the established React Native pattern used elsewhere in the codebase.Changelog:
[iOS][Changed] - Adds localization for Text Input default return key types
Differential Revision: D108270298