feat(style): remove experimental_ prefix from backgroundImage#57165
Open
intergalacticspacehighway wants to merge 4 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Promote `backgroundImage` from `experimental_backgroundImage` to a stable style prop. `backgroundSize`, `backgroundPosition`, and `backgroundRepeat` remain experimental.
intergalacticspacehighway
force-pushed
the
remove-experimental-background-image-prefix
branch
from
311994e to
568bc32
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
Author
|
cc - @jorge-cab reopening the previous PR here. I deleted my old fork as I was not able to push to it after the repo org change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Promote
backgroundImagefromexperimental_backgroundImageto a stable style prop. It has been available in experimental mode for some time and is already used in popular open-source projects such as NativeWind, Unstyles, Tamagui, React Strict DOM, and others, with no reported issues so far.backgroundImagecurrently supportslinear-gradientandradial-gradient.url()support already has a PR up (PRs), it should not be a blocker imo though as gradient is also a big unlock.Changelog:
[GENERAL][CHANGED] - Remove
experimental_prefix frombackgroundImageTest Plan:
Tested background image screen on RNTester.